svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf

[Warner Losh]

> On Dec 31, 2014, at 10:12 PM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> 
> On Dec 31, 2014, at 20:44, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> 
>> On Dec 31, 2014, at 20:25, Warner Losh <imp at bsdimp.com> wrote:
> 
> …
> 
>>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit.
>> 
>> Sorry. Should have asked first. Now the build is broken on all architectures :/. What next?
> 
> Also, that code has been in there for over a decade. It seems a bit dangerous to remove it without at least a ports -exp or make tinderbox run…

True. However, this code has been wrong for a very long time since the WARNS kris added were just for user land. Too bad the std stuff got mixed in over the years.

Warner

> $ svn blame -r 231834 share/mk/bsd.kmod.mk | less
> 60963      peter # $FreeBSD$
> 60963      peter
> 60963      peter # Search for kernel source tree in standard places.
> 130835        pjd .for _dir in ${.CURDIR}/../.. ${.CURDIR}/../../.. ${.CURDIR}/../../../.. \
> 183736        imp     ${.CURDIR}/../../../../.. /sys /usr/src/sys
> 130835        pjd .if !defined(SYSDIR) && exists(${_dir}/kern/) && exists(${_dir}/conf/kmod.mk)
> 60963      peter SYSDIR=       ${_dir}
> 60963      peter .endif
> 60963      peter .endfor
> 130835        pjd .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || \
> 130835        pjd     !exists(${SYSDIR}/conf/kmod.mk)
> 231834        imp .error Unable to locate the kernel source tree. Set SYSDIR to override.
> 60963      peter .endif
> 60963      peter
> 60965      peter .include "${SYSDIR}/conf/kmod.mk"
> 76861       kris
> 76861       kris .include <bsd.sys.mk>
> [ngie at fuji-current-amd64 /usr/src.svn]$ svn log -r 76861
> ------------------------------------------------------------------------
> r76861 | kris | 2001-05-19 16:18:21 -0700 (Sat, 19 May 2001) | 8 lines
> 
> Bring in the WARNS directive from NetBSD, localized in a new bsd.sys.mk
> to avoid polluting sys.mk.  This directive controls the addition of
> compiler warning flags to CFLAGS in a relatively compiler-neutral manner.
> 
> The idea is that WARNS can be set in Makefile.inc or in individual
> Makefiles as they become clean, to prevent the introduction of new
> warnings in the code.  -Werror is added by default
> 
> ------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20141231/d2b87dd7/attachment.sig>