svn commit: r278914 - in head/sys: kern sys

[Alexey Dokuchaev]

On Wed, Feb 25, 2015 at 05:04:07PM -0500, Ed Maste wrote:
> On 25 February 2015 at 14:47, John Baldwin <jhb at freebsd.org> wrote:
> > On Wednesday, February 25, 2015 01:40:04 PM Alexey Dokuchaev wrote:
> >>
> >> In r278673 I used full URL to D1801, but it was not closed for some
> >> reason.  Could it be that rS (src repository) entries auto-closed when
> >> committed by src-folks only?
> >
> > It seems like it might not close a differential that hasn't been accepted
> > yet [...]

That would make sense, but I've certainly had committed proposed patch after
D1801 was accepted (twice).

> I think this is an intermittent failure in Phabricator. I expect it to
> close upon commit regardless of the state of the review.

Assuming (for now) that it is some weird failure, I've manually closed D1801
and provided correct auto-close-like message (citing SVN revision and author
links).

On a related note: while searching for proper auto-close message, I've found
that many differentials are closed without marking SVN revision as such, so
it does not link to it directly.  This is not nice; we should make sure that
these "dots are connected".

./danfe