svn commit: r278889 - head/lib/libc/include

[Bryan Drewery]

On 2/18/2015 6:58 PM, Bruce Evans wrote:
> On Wed, 18 Feb 2015, Bryan Drewery wrote:
> 
>> On 2/17/2015 2:54 AM, Konstantin Belousov wrote:
>>> ...
>>> Log:
>>>   Restore the extern qualifier on __cleanup.
>>> ...
>>> Modified: head/lib/libc/include/libc_private.h
>>> ==============================================================================
>>>
>>> --- head/lib/libc/include/libc_private.h    Tue Feb 17 08:50:26
>>> 2015    (r278888)
>>> +++ head/lib/libc/include/libc_private.h    Tue Feb 17 08:54:03
>>> 2015    (r278889)
>>> @@ -271,7 +271,7 @@ void _malloc_first_thread(void);
>>>  /*
>>>   * Function to clean up streams, called from abort() and exit().
>>>   */
>>> -void (*__cleanup)(void) __hidden;
>>> +extern void (*__cleanup)(void) __hidden;
>>>
>>>  /*
>>>   * Get kern.osreldate to detect ABI revisions.  Explicitly
>>>
>>
>> Is this a NOP?
> 
> No, since this is a data declaration.  It would be a style bug on a
> prototype.

Ah, of course. I missed the *, despite the ().

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150218/3da35beb/attachment.sig>