svn commit: r278961 - stable/10/usr.sbin/binmiscctl

Sean Bruno sbruno at FreeBSD.org
Wed Feb 18 16:28:56 UTC 2015


Author: sbruno
Date: Wed Feb 18 16:28:55 2015
New Revision: 278961
URL: https://svnweb.freebsd.org/changeset/base/278961

Log:
  MFC r278827
  
  Check for required arguments before accessing argv[0] and core dumping.

Modified:
  stable/10/usr.sbin/binmiscctl/binmiscctl.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/binmiscctl/binmiscctl.c
==============================================================================
--- stable/10/usr.sbin/binmiscctl/binmiscctl.c	Wed Feb 18 15:25:25 2015	(r278960)
+++ stable/10/usr.sbin/binmiscctl/binmiscctl.c	Wed Feb 18 16:28:55 2015	(r278961)
@@ -371,8 +371,10 @@ add_cmd(__unused int argc, char *argv[],
 }
 
 int
-name_cmd(__unused int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
+name_cmd(int argc, char *argv[], ximgact_binmisc_entry_t *xbe)
 {
+	if (argc == 0)
+		usage("Required argument missing\n");
 	if (strlen(argv[0]) > IBE_NAME_MAX)
 		usage("'%s' string length longer than IBE_NAME_MAX (%d)",
 		    IBE_NAME_MAX);


More information about the svn-src-all mailing list