svn commit: r278828 - head/sys/netinet6
Bjoern A. Zeeb
bz at FreeBSD.org
Mon Feb 16 08:38:44 UTC 2015
> On 16 Feb 2015, at 03:36 , Gleb Smirnoff <glebius at freebsd.org> wrote:
>
> On Mon, Feb 16, 2015 at 01:34:09AM +0000, Bjoern A. Zeeb wrote:
> B>
> B> > On 16 Feb 2015, at 01:30 , Gleb Smirnoff <glebius at FreeBSD.org> wrote:
> B> >
> B> > On Mon, Feb 16, 2015 at 01:25:05AM +0000, Bjoern A. Zeeb wrote:
> B> > B>
> B> > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff <glebius at freebsd.org> wrote:
> B> > B> >
> B> > B> > Author: glebius
> B> > B> > Date: Mon Feb 16 01:12:20 2015
> B> > B> > New Revision: 278828
> B> > B> > URL: https://svnweb.freebsd.org/changeset/base/278828
> B> > B> >
> B> > B> > Log:
> B> > B> > Factor out ip6_deletefraghdr() function, to be shared between IPv6
> B> > B> > stack and pf(4).
> B> > B> >
> B> > B> > Submitted by: Kristof Provost
> B> > B> > Reviewed by: ae
> B> > B> > Differential Revision: D1764
> B> > B> >
> B> > B> > Modified:
> B> > B> > head/sys/netinet6/frag6.c
> B> > B> > head/sys/netinet6/ip6_output.c
> B> > B>
> B> > B> Why did it have to move file?
> B>
> B> But the new function is in ip6_output and the consumer stays in frag6 and will be in pf? So the new function moved to a different file without consumer rather than just on top of the old function? Keep code logically together seems to make more sense to me. What am I missing?
>
> You are right. I somehow misread it as function being in frag6.c and consumer
> in ip6_output.c. Will fix.
Thanks!
More information about the svn-src-all
mailing list