svn commit: r276747 - head/sys/netpfil/pf

[Craig Rodrigues]

On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff <glebius at freebsd.org> wrote:

> On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote:
> C> By the way, it would be helpful if you could provide feedback in
> C> Phabricator.  When I created those Phabricator reviews, I added
> C> you as a reviewer to all of them, so you can't say that you didn't see
> C> the patches.
> C> You did not provide feedback on any of them:
> C>
> C> https://reviews.freebsd.org/D1309
> C> https://reviews.freebsd.org/D1312
> C> https://reviews.freebsd.org/D1313
> C> https://reviews.freebsd.org/D1315
> C>
> C> Please take some time to go and provide feedback in those
> C> reviews, so that a better patch can be made that makes you happy.
>
> Did you address all problems that arised after code was committed?
>
> Please do, otherwise my review would require me to cut-n-paste from
> my own emails.
>

Yes, please cut and paste from your e-mails, and put in the reviews.
It's easier to follow in the individual reviews because there are different
changes
in each review, rather than one big revert, which is what you did.

Thanks.
--
Craig