svn commit: r276747 - head/sys/netpfil/pf

[Gleb Smirnoff]

On Sun, Feb 15, 2015 at 01:26:18PM -0800, Craig Rodrigues wrote:
C> What are the problems in 276746 that you were unhappy with
C> besides being unable to kldunload PF?

They were listed in Message-ID: <20150121214445.GL15484 at FreeBSD.org>.

Also, the fact that commit required a serie of followup commits,
means that initial commit was not tested properly.

And did I ever said "being unable to kldunload PF"? This is what I
said:

> You blindly remove kproc_exit(). What do you think would happen on
> 'kldunload -f pf'?

If you can't grok that, you probably don't even understand the code
you committed. Since what is going to happen is kernel panic.

C> With 276746, without the follow-on fixes, if you kldunload PF
C> while VIMAGE is unabled, the kernel panics.  That seems worse
C> than being unable to kldunload PF.

So, without 276746 pf would panic with VIMAGE. And after 276747
pf would panic without VIMAGE. And yes, this is worse. Since
backing out only 276747 leads to unbuildable kernel, I ended
with backing out all chain of commits.

C> If I submit another patch, I am just going to commit it,
C> but I don't know if you will be unhappy and revert it.

No, you will wait for review.

-- 
Totus tuus, Glebius.