svn commit: r278623 - head/sys/kern

Peter Holm peter at holm.cc
Fri Feb 13 19:11:16 UTC 2015


On Fri, Feb 13, 2015 at 10:29:01AM -0800, hiren panchasara wrote:
> On 02/12/15 at 01:31P, Randall Stewart wrote:
> > Author: rrs
> > Date: Thu Feb 12 13:31:08 2015
> > New Revision: 278623
> > URL: https://svnweb.freebsd.org/changeset/base/278623
> > 
> > Log:
> >   This fixes a bug I in-advertantly inserted when I updated the callout
> >   code in my last commit. The cc_exec_next is used to track the next
> >   when a direct call is being made from callout. It is *never* used
> >   in the in-direct method. When macro-izing I made it so that it
> >   would separate out direct/vs/non-direct. This is incorrect and can
> >   cause panics as Peter Holm has found for me (Thanks so much Peter for
> >   all your help in this). What this change does is restore that behavior
> >   but also get rid of the cc_next from the array and instead make it
> >   be part of the base callout structure. This way no one else will get
> >   confused since we will never use it for non-direct.
> >   
> >   Reviewed by:	Peter Holm and more importantly tested by him ;-)
> >   MFC after:	3 days.
> >   Sponsored by:	Netflix Inc.
> 
> Can I get more info/backtraces for the panic, please?
> 

Sure.

These two panics were seen:

http://people.freebsd.org/~pho/stress/log/rrs004.txt
http://people.freebsd.org/~pho/stress/log/rrs005.txt

- Peter


More information about the svn-src-all mailing list