svn commit: r278371 - head/sys/dev/cxgbe

Navdeep Parhar np at FreeBSD.org
Sun Feb 8 08:42:46 UTC 2015


Author: np
Date: Sun Feb  8 08:42:45 2015
New Revision: 278371
URL: https://svnweb.freebsd.org/changeset/base/278371

Log:
  cxgbe(4): a change to the synchronization rules within the the driver.
  This is purely cosmetic because the new rules are already followed.
  
  MFC after:	1 week

Modified:
  head/sys/dev/cxgbe/adapter.h
  head/sys/dev/cxgbe/t4_main.c

Modified: head/sys/dev/cxgbe/adapter.h
==============================================================================
--- head/sys/dev/cxgbe/adapter.h	Sun Feb  8 03:55:12 2015	(r278370)
+++ head/sys/dev/cxgbe/adapter.h	Sun Feb  8 08:42:45 2015	(r278371)
@@ -812,7 +812,6 @@ struct adapter {
 #define ADAPTER_LOCK_ASSERT_OWNED(sc)	mtx_assert(&(sc)->sc_lock, MA_OWNED)
 #define ADAPTER_LOCK_ASSERT_NOTOWNED(sc) mtx_assert(&(sc)->sc_lock, MA_NOTOWNED)
 
-/* XXX: not bulletproof, but much better than nothing */
 #define ASSERT_SYNCHRONIZED_OP(sc)	\
     KASSERT(IS_BUSY(sc) && \
 	(mtx_owned(&(sc)->sc_lock) || sc->last_op_thr == curthread), \

Modified: head/sys/dev/cxgbe/t4_main.c
==============================================================================
--- head/sys/dev/cxgbe/t4_main.c	Sun Feb  8 03:55:12 2015	(r278370)
+++ head/sys/dev/cxgbe/t4_main.c	Sun Feb  8 08:42:45 2015	(r278371)
@@ -3139,6 +3139,9 @@ mcfail:
 	return (rc);
 }
 
+/*
+ * {begin|end}_synchronized_op must be called from the same thread.
+ */
 int
 begin_synchronized_op(struct adapter *sc, struct port_info *pi, int flags,
     char *wmesg)
@@ -3194,6 +3197,9 @@ done:
 	return (rc);
 }
 
+/*
+ * {begin|end}_synchronized_op must be called from the same thread.
+ */
 void
 end_synchronized_op(struct adapter *sc, int flags)
 {


More information about the svn-src-all mailing list