svn commit: r292823 - in stable/10/sys: conf netinet

[Patrick Kelsey]

> On Dec 27, 2015, at 10:16 PM, Andrey Chernov <ache at freebsd.org> wrote:
> 
>> On 28.12.2015 5:59, Andrey Chernov wrote:
>>> On 28.12.2015 5:43, Patrick Kelsey wrote:
>>> Author: pkelsey
>>> Date: Mon Dec 28 02:43:12 2015
>>> New Revision: 292823
>>> URL: https://svnweb.freebsd.org/changeset/base/292823
>>> 
>>> Log:
>>>  MFC r292706:
>>> 
>>>  Implementation of server-side TCP Fast Open (TFO) [RFC7413].
>>> 
>>>  TFO is disabled by default in the kernel build.  See the top comment
>>>  in sys/netinet/tcp_fastopen.c for implementation particulars.
>> 
>> Why it is disabled by default? Do we need some rc.conf knobs to not deal
>> directly with it, like tcp_extensions? OMG, why it is kernel config and
>> not boot-time sysctl?
> 
> BTW, TCP_RFC7413_MAX_KEYS currently unused and I have no clues what it
> supposed to be. I can't find it in the phabric patch at all.
> 

Look at line 127 in tcp_fastopen.c.  Also, read the top comment in tcp_fastopen.c.

Phabricator is buggy and unreliable, and using it as a primary reference to the code will let you down as it has let me down, repeatedly.  For example, it will not show you the contents of entirely new files unless you manually upload them - I believe this what is currently affecting your viewpoint.

-Patrick