svn commit: r291994 - head/include

Hajimu UMEMOTO ume at FreeBSD.org
Wed Dec 9 02:19:05 UTC 2015


Hi,

>>>>> On Tue, 8 Dec 2015 16:09:48 +0000 (UTC)
>>>>> Eric van Gyzen <vangyzen at FreeBSD.org> said:

vangyzen> Author: vangyzen
vangyzen> Date: Tue Dec  8 16:09:48 2015
vangyzen> New Revision: 291994
vangyzen> URL: https://svnweb.freebsd.org/changeset/base/291994

vangyzen> Log:
vangyzen>   resolver: fix the build of some ports, broken by r289315
vangyzen>   
vangyzen>   r289315 required time_t and struct timespec to be defined before
vangyzen>   including <resolv.h>.  This broke the build of net-mgmt/sx, at least.
vangyzen>   
vangyzen>   Include <sys/timespec.h> in resolv.h to fix this with minimal pollution.
vangyzen>   
vangyzen>   Reported by:	Raphael Kubo da Costa <rakuco>
vangyzen>   MFC after:	3 days
vangyzen>   Sponsored by:	Dell Inc.

It seems wrong.  We should not have pollution from timespec.h, here.
You should consider moving them into __res_state_ext like NetBSD does.

Sincerely,

--
Hajimu UMEMOTO
ume at mahoroba.org  ume at FreeBSD.org
http://www.mahoroba.org/~ume/


More information about the svn-src-all mailing list