svn commit: r291592 - head/usr.bin/netstat

[Ravi Pokala]

-----Original Message-----


From: Hajimu UMEMOTO <ume at FreeBSD.org>
Date: 2015-12-01, Tuesday at 08:26
To: Ravi Pokala <rpokala at mac.com>
Cc: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r291592 - head/usr.bin/netstat

>Hi,
>
>>>>>> On Tue, 01 Dec 2015 08:13:41 -0800
>>>>>> Ravi Pokala <rpokala at mac.com> said:
>
>rpokala> The value returned by p_sockaddr("destination", ...) is saved to "protrusion", but it is never used before it is overwritten by the value returned by p_sockaddr("gateway", ...). That doesn't seem right.
>
>The protrusion is given to the argument of next p_sockaddr() call.

<facepalm>

How did I miss that? Looks like it's time for new glasses. :-/

-Ravi

>Sincerely,
>
>--
>Hajimu UMEMOTO
>ume at mahoroba.org  ume at FreeBSD.org
>http://www.mahoroba.org/~ume/