svn commit: r287236 - head/bin/df

[Alexey Dokuchaev]

On Fri, Aug 28, 2015 at 12:00:26PM -0400, Allan Jude wrote:
> On 2015-08-28 03:48, Garrett Cooper wrote:
> >> On Aug 28, 2015, at 00:24, O'Connor, Daniel <darius at dons.net.au> wrote:
> >>> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> >>>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote:
> >>>>
> >>>> Probably because of libxo...
> >>>
> >>> I'm just wondering how hard is it to write sensible commit logs. :(
> >>
> >> To put it in a hopefully more helpful way..
> >> Please write why your change is doing something, not what it is doing.
> >>
> >> Saying what it is doing is OK if it's really hairy, but 99% of the time
> >> that isn't the case.
> >>
> >> Assuming this is a libxo thing the commit log should have been
> >> something like.. "Use exit out of main otherwise libxo will not flush
> >> properly" (or something similar)
> >>
> >> Although it would be surprising if libxo required you to use exit()..
> > 
> > Libxo (iirc) doesn't install atexit handlers, which means that you need
> > to use exit (or a reason facsimile) in order for it to flush its file
> > streams.
> > 
> > This is unintuitive though. I wish it did the right thing as part of
> > initializing the streams..
> 
> This has nothing to do with libxo. libxo has an optional atexit handler,
> but as long as you call xo_finish(), then everything is flushed and the
> xo handle is closed. xo_finish() is indeed called the line before this
> change.

Funny how much hypotheses/guesses/speculations it had caused.  Which just
proves the necessity of good commit logs.

But some of us had probably learned a few things about exit(), atexit
handlers, flushing the file streams, etc. so thanks for that guys. :)

./danfe