svn commit: r287236 - head/bin/df

[O'Connor, Daniel]

> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote:
>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote:
>>>> New Revision: 287236
>>>> URL: https://svnweb.freebsd.org/changeset/base/287236
>>>> 
>>>> Log:
>>>>  Use exit() instead of return in main().
>>> 
>>> Because?..
>> 
>> Probably because of libxo...
> 
> I'm just wondering how hard is it to write sensible commit logs. :(

To put it in a hopefully more helpful way..
Please write why your change is doing something, not what it is doing.

Saying what it is doing is OK if it's really hairy, but 99% of the time that isn't the case.

Assuming this is a libxo thing the commit log should have been something like..
"Use exit out of main otherwise libxo will not flush properly"
(or something similar)

Although it would be surprising if libxo required you to use exit()..

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C