svn commit: r286955 - in head/sys: net netinet netinet6

Bjoern A. Zeeb bz at FreeBSD.org
Thu Aug 20 13:29:27 UTC 2015


> On 20 Aug 2015, at 13:13 , George Neville-Neil <gnn at neville-neil.com> wrote:
> 
> Why was this work not in Phabricator?  This is a large change that has not been reviewed,
> as far as I can tell, by anyone else on the project.  I am tempted to ask that this be backed out
> and reviewed BEFORE it goes into the tree.

I probably wouldn’t go as far as backing out.

Given this seems part of a larger change that seem to be streamed into HEAD and I have probably missed a posting or heads up or something on net@ [if someone could point me at that it would be very helpful], I appreciate things being broken into smaller reviewable bits.  I have no clear idea of what the end goal is or will be or look like, which makes it hard to comment on design decisions.

I however, as I have stated in the past, would really really appreciate each change in PB, with the proposed commit message, and allow a few days of review or for people to comment on.  I have spend two years on fixing bugs on the previous rewrite of that code.   I am not exactly looking forward to see history repeat itself.

Thanks,
Bjoern




More information about the svn-src-all mailing list