svn commit: r286601 - head/usr.bin/patch

[Xin Li]

On 08/10/15 14:42, Ed Schouten wrote:
> Hi Xin,
> 
> Something I forgot to mention in my previous email:
> 
> 2015-08-10 23:31 GMT+02:00 Xin LI <delphij at freebsd.org>:
>> +                               argp[0] = strdup(RCSDIFF);
>> +                               argp[1] = strdup(filename);
> 
>> +                       argp[0] = strdup(CHECKOUT);
>> +                       argp[1] = strdup("-l");
>> +                       argp[2] = strdup(filename);
> 
> While we're at it, should we also add "--" before the filename, or can
> we be sure in this context that they don't start with a dash?

We can't be sure.

However, neither co nor rcsdiff supports "--", so it won't make a
difference.

Cheers,
-- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150810/098e717d/attachment.bin>