svn commit: r282211 - head/tests/freebsd_test_suite

[Garrett Cooper]

On Apr 29, 2015, at 4:29, Gleb Smirnoff <glebius at FreeBSD.org> wrote:

> On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote:
> G> Author: ngie
> G> Date: Wed Apr 29 08:56:56 2015
> G> New Revision: 282211
> G> URL: https://svnweb.freebsd.org/changeset/base/282211
> G>
> G> Log:
> G>   ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so the testcase
> G>   no longer bombs out
> G>   PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the testcase no
> G>   longer bombs out if it prints to stderr
> G>
> G>   MFC after: 5 days
> 
> This breaks buildworld since atf_skip() is a shell function, not a C one:
> 
> glebius at behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c
> glebius at behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/
> atf-sh/atf-sh.3:.Nm atf_skip ,

Yeah. I should really stop committing things after midnight and should have gotten CRs/produced tests which would have proved that my code was broken twice :(. Fixed in r282244..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150429/3e196ee4/attachment.sig>