svn commit: r281181 - head/usr.bin/sort
Pedro Giffuni
pfg at FreeBSD.org
Tue Apr 7 14:24:33 UTC 2015
On 04/06/15 23:26, Eitan Adler wrote:
> On 6 April 2015 at 21:17, Pedro F. Giffuni <pfg at freebsd.org> wrote:
>> Author: pfg
>> Date: Tue Apr 7 01:17:29 2015
>> New Revision: 281181
>> URL: https://svnweb.freebsd.org/changeset/base/281181
>>
>> Log:
>> sort(1): Cleanups and a small memory leak.
>>
>> Remove useless check for leading blanks in the month name. The
>> code didn't adjust len after stripping blanks so even if a month
>> *did* start with a blank we'd end up copying garbage at the end.
>> Also convert a malloc + memcpy to strdup and fix a memory leak in
>> the wide char version if mbstowcs() fails.
>> Originally from Andre Smagin.
>>
>> Obtained from: OpenBSD (CVS rev. 1.2, 1.3)
>> MFC after: 1 week
> Thanks for porting all these cleanups!
>
I am not over, but they have started doing many unnecessary
changes that I have no interest in.
I am also wondering if we should give up the GNU behavior
our sort(1) adopted.
Pedro.
More information about the svn-src-all
mailing list