svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Will Andrews]

I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this
particular implementation of the tunable, so there is a regression
that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no
matter what's in loader.conf).  I believe it's limited to this
particular tunable, however, because I tested another SYSCTL_PROC that
had CTLFLAG_TUN set and it worked.

--Will.

On Fri, Sep 19, 2014 at 10:34 AM, John Baldwin <jhb at freebsd.org> wrote:
> On Thursday, September 18, 2014 06:37:28 PM Steven Hartland wrote:
>> You don't need a seperate TUNABLE_INT declations any more since the
>> excellent SYSCTL refactor.
>
> That is my fault.  I wasn't certain if SYSCTL_PROC() would work correctly when
> Will asked me on IRC, but it seems it does so long as the tunable type is one
> it knows how to parse (e.g. CTLTYPE_INT).  If your sysctl wants a "blob"
> (CTLTYPE_OPAQUE or the like), then you still need your own tunable fetching
> handler.
>
> --
> John Baldwin