svn commit: r271792 - head/include

[Pedro Giffuni]

Il giorno 18/set/2014, alle ore 20:52, Kevin Lo <kevlo at FreeBSD.org> ha scritto:

> On Thu, Sep 18, 2014 at 05:18:43PM +0000, Pedro F. Giffuni wrote:
>> 
>> Author: pfg
>> Date: Thu Sep 18 17:18:42 2014
>> New Revision: 271792
>> URL: http://svnweb.freebsd.org/changeset/base/271792
>> 
>> Log:
>>  unistd: move setpgrp(2) to the __BSD_VISIBLE section
>> 
>>  Our setpgrp(2) differs from the specified by POSIX, which
>>  only has one argument, and is only meant for compatibility
>>  with BSD.
>> 
>>  Reference:
>>  http://pubs.opengroup.org/onlinepubs/009695399/functions/setpgrp.html
>> 
>>  Pointed-out in:	openbsd-tech (2014-09-16)
>>  MFC after:	6 weeks
>> 
>> Modified:
>>  head/include/unistd.h
>> 
>> Modified: head/include/unistd.h
>> ==============================================================================
>> --- head/include/unistd.h	Thu Sep 18 17:15:38 2014	(r271791)
>> +++ head/include/unistd.h	Thu Sep 18 17:18:42 2014	(r271792)
>> @@ -453,7 +453,6 @@ int	 encrypt(char *, int);
>> long	 gethostid(void);
>> int	 lockf(int, int, off_t);
>> int	 nice(int);
>> -int	 setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */
>> int	 setregid(gid_t, gid_t);
>> int	 setreuid(uid_t, uid_t);
>> 
>> @@ -567,6 +566,7 @@ int	 setkey(const char *);
>> int	 setlogin(const char *);
>> int	 setloginclass(const char *);
>> void	*setmode(const char *);
>> +int	 setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */
>> void	 setproctitle(const char *_fmt, ...) __printf0like(1, 2);
>> int	 setresgid(gid_t, gid_t, gid_t);
>> int	 setresuid(uid_t, uid_t, uid_t);
> 
> Since there are no prototypes in unistd.h include arguments, 
> I'd be inclined to drop them for consistency.
> 

The effect on ports would have to be evaluated first, but TBH I don’t find
having this extra function around for a while troublesome at all.

FWIW, strtoq and strtouq, in stdlib.h, are more “interesting”.
 
Pedro.