svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/dev/bxe sys/modules/bce

[David Somayajulu]

Hi Andrey,
When I didn't have the clean override,  "make clean" was not cleaning properly when I built a standalone loadable driver. Perhaps we can change "clean" in bxe/Makefile and bce/Makefile to "dclean".

Thanks
David S.
-----Original Message-----
From: Andrey V. Elsukov [mailto:ae at FreeBSD.org]
Sent: Sunday, September 14, 2014 10:00 PM
To: David C Somayajulu; src-committers at freebsd.org; svn-src-all at freebsd.org; svn-src-head at freebsd.org
Subject: Re: svn commit: r265703 - in head: share/man/man4 sys/dev/bce sys/dev/bxe sys/modules/bce

On 08.05.2014 23:40, David C Somayajulu wrote:
> Author: davidcs
> Date: Thu May  8 19:40:37 2014
> New Revision: 265703
> URL: http://svnweb.freebsd.org/changeset/base/265703

> Modified: head/sys/modules/bce/Makefile
> ==============================================================================
> --- head/sys/modules/bce/Makefile     Thu May  8 19:35:29 2014        (r265702)
> +++ head/sys/modules/bce/Makefile     Thu May  8 19:40:37 2014        (r265703)
> @@ -5,4 +5,9 @@ SRCS= opt_bce.h if_bce.c miibus_if.h mii
>
>  #CFLAGS += -DBCE_DEBUG=0
>
> +clean:
> +     rm -f opt_bdg.h device_if.h bus_if.h pci_if.h export_syms
> +     rm -f *.o *.kld *.ko
> +     rm -f @ machine x86 miibus_if.h miidevs.h opt_bce.h
> +
>  .include <bsd.kmod.mk>

Hi,

why did you override 'clean' target?
It works well by default, but now some files don't deleted, e.g. when you build modules with DEBUG_FLAGS. Also the same problem with if_bxe(4) module.

--
WBR, Andrey V. Elsukov

________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.