svn commit: r271243 - head/sys/vm

[Alan Cox]

On 09/07/2014 21:14, Peter Wemm wrote:
> On Monday, September 08, 2014 12:19:04 AM Alan Cox wrote:
>
>> Log:
>>   Make two functions static and eliminate an unused #define.
>
> Unfortunately, the code (and compiler) disagrees..
>
>> @@ -1504,7 +1507,7 @@ again:
>>   *    possibly extended).  When merging, this routine may delete one or
>>   *    both neighbors.
>>   */
>> -void
>> +static void
>>  vm_map_simplify_entry(vm_map_t map, vm_map_entry_t entry)
>>  {
>>      vm_map_entry_t next, prev;
>
>
> sys/security/mac/mac_process.c:366:4: error: implicit declaration of
function
> 'vm_map_simplify_entry' is invalid in C99 [-Werror,-Wimplicit-function-
> declaration]
>                         vm_map_simplify_entry(map, vme);
>
> The code in question:
>
> static void
> mac_proc_vm_revoke_recurse(struct thread *td, struct ucred *cred,
>     struct vm_map *map)
> {
>         vm_map_entry_t vme;
> ...
>                         vm_map_simplify_entry(map, vme);
>                    ^^^^^^^^^^^^^^^^^^^^^^
>                 }
>         }
>         vm_map_unlock(map);
> }
>
>

Ya, I just saw that, and was rather surprised.