svn commit: r273734 - head/bin/dd
Ian Lepore
ian at FreeBSD.org
Mon Oct 27 17:09:07 UTC 2014
On Mon, 2014-10-27 at 17:20 +0100, Kurt Jaeger wrote:
> Hi!
>
> > > Log:
> > > bin/dd: Fix incorrect casting of arguments
> [...]
> > Both of these work correctly in my version (with a relatively small patch
> > and no breakage of other cases). (I actually typed large values as -1
> > and 11111111111111111111111111. -1 means (uintmax_t)-1 although this
> > is undocumented and now broken).
>
> So, given this detailed review, should I revert the change ?
>
Given that it breaks the build for 32 bit architectures, it probably
should be reverted until a different set of changes is available.
-- Ian
More information about the svn-src-all
mailing list