svn commit: r273417 - head

Warner Losh imp at bsdimp.com
Wed Oct 22 16:39:39 UTC 2014


On Oct 22, 2014, at 8:57 AM, Dag-Erling Smørgrav <des at des.no> wrote:

> Warner Losh <imp at bsdimp.com> writes:
>> Dag-Erling Smørgrav <des at des.no> writes:
>>> I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though.
>>> The test framework is probably useful on its own.
>> That would be a nicer name, but then we’d lose the automatic setting
>> when MK_TESTS is enabled (unless we add another special case, which is
>> the opposite direction that I want to go in). How strongly do you feel
>> that’s a better name?
> 
> Is _SUPPORT magic?  I didn't know.  I guess MK_TESTS_SUPPORT is good
> enough, especially if it's on by default.

It is magic.  Though one can replicate similar magic with MK_TESTS and MK_ATF
if one wanted to do so (there’s a second list of defaults based on settings that have
unrelated names), though that list is much smaller and used in much more obscure
areas of the system.

Warner

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20141022/aebdddfe/attachment.sig>


More information about the svn-src-all mailing list