svn commit: r273174 - in head/sys: amd64/amd64 amd64/vmm arm/arm cam/ata cddl/contrib/opensolaris/uts/common/dtrace dev/acpica dev/asmc dev/cfi dev/drm2 dev/hatm dev/mii dev/nfe dev/patm dev/pci de...

[Davide Italiano]

On Thu, Oct 16, 2014 at 4:44 PM, Bjoern A. Zeeb <bz at freebsd.org> wrote:
>
> On 16 Oct 2014, at 18:04 , Davide Italiano <davide at FreeBSD.org> wrote:
>
>> Author: davide
>> Date: Thu Oct 16 18:04:43 2014
>> New Revision: 273174
>> URL: https://svnweb.freebsd.org/changeset/base/273174
>>
>> Log:
>>  Follow up to r225617. In order to maximize the re-usability of kernel code
>>  in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv().
>>  This fixes a namespace collision with libc symbols.
>>
>>  Submitted by:   kmacy
>>  Tested by:      make universe
>
> Hmm I still see a lot of mips kernels broken with
>
> /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c: In function 'platform_start':
> /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c:461: warning: implicit declaration of function 'setenv'
> /scratch/tmp/bz/head.svn/sys/mips/rmi/xlr_machdep.c:461: warning: nested extern declaration of ‘setenv’ [-Wnested-externs]
>
> on my incremental builds.
>
> —
> Bjoern A. Zeeb             "Come on. Learn, goddamn it.", WarGames, 1983
>

Hi,
I think you're right and I apologize for the breakage (apparently I
didn't look at all the log files properly).
Can you tell me if this fixes for you:
https://people.freebsd.org/~davide/patches/kernsetenv_fixup.diff ?
If yes, I'll commit.
BTW, it would be cool if universe will put logs of successful builds
and logs of failed builds in different directories for easier
inspection.
If there's already something like this and you can point me to that,
it would be appreciated.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare