svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys

Ed Maste emaste at freebsd.org
Wed Oct 15 13:10:32 UTC 2014


On 15 October 2014 05:21, Dag-Erling Smørgrav <des at des.no> wrote:
>
> That's my fault, and I'm going to change it, because it's illogical.
> The function works on aligned arrays of int32s and should take a count,
> not a size.  I just didn't want to delay the patch even further.

The fact that it works only on aligned 32-bit ints is a detail of this
implementation and not a requirement of murmur3 though. AFAICT common
implementations treat this case as an optimization but handle
arbitrarily aligned buffers of arbitrary numbers of bytes, as is the
case for other hashes in my quick survey.

The reference Jenkins hash looks to be the odd one out here in taking
a uint32_t * and a count rather than a char * or void * and a byte
length.


More information about the svn-src-all mailing list