svn commit: r270122 - in stable/10: . lib/libopie

[Andrey Chernov]

On 10.10.2014 19:17, Andrey Chernov wrote:
> On 10.10.2014 19:11, Andrey Chernov wrote:
>> On 10.10.2014 19:02, Hiroki Sato wrote:
>>> ac> It is strange that nobody notice that so far. Is there any packages
>>> ac> which builds with libopie? If no, there is no problem. If yes, what you
>>>
>>>  cyrus-sasl uses it.
>>>
>>> ac> suggest to fix, is that backing out? If yes, when exactly this change
>>> ac> can be merged to -stable (because -stable always stays -stable, so from
>>> ac> your sentence it means - never can be merged).
>>>
>>>  Is it impossible to handle this by symbol versioning instead of shlib
>>>  version bump?
>>
>> There is buffer size #define change (it was too small in unfixed
>> version, so discards valid input), the buffer itself is in the userland
>> programs, not in the library. AFAIK symbol versioning is for functions,
>> not for such changes but I can be wrong, I know very little about symbol
>> versioning procedure.
> 
> From other hand, the check for buffer size is in the library, so the
> function which does the check can be versioned, but I still don't know
> how exactly to do that.
> 

It does not help in general case. Such checks can be in the userland
too. So, backing out buffer size change and major version bump for
-stable, right?

-- 
http://ache.vniz.net/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20141010/9d42c977/attachment.sig>