svn commit: r272738 - in head/sys: dev/mrsas modules/mrsas modules/mrsas/mrsas_linux

[Steven Hartland]

I thought it was convension to avoid using $FreeBSD$ in code comments instead use the __FBSDID e.g. 

#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>

Could anyone confirm?

    Regards
    Steve

----- Original Message ----- 
From: "Kashyap D Desai" <kadesai at FreeBSD.org>
To: <src-committers at freebsd.org>; <svn-src-all at freebsd.org>; <svn-src-head at freebsd.org>
Sent: Wednesday, October 08, 2014 10:30 AM
Subject: svn commit: r272738 - in head/sys: dev/mrsas modules/mrsas modules/mrsas/mrsas_linux


> Author: kadesai
> Date: Wed Oct  8 09:30:35 2014
> New Revision: 272738
> URL: https://svnweb.freebsd.org/changeset/base/272738
> 
> Log:
>  Fix the minor svn add issue. $FreeBSD$ expands at the time of
>  snv add, so I have added $FreeBSD$ as comment.
>  
>  This commit is contininous of last mrsas commit, so that compilation
>  does not break.
>  
>  Obtained from: AVAGO Technologies
>  MFC after: 2 weeks
> 
> Modified:
>  head/sys/dev/mrsas/mrsas_linux.c
>  head/sys/modules/mrsas/Makefile
>  head/sys/modules/mrsas/mrsas_linux/Makefile
> 
> Modified: head/sys/dev/mrsas/mrsas_linux.c
> ==============================================================================
> --- head/sys/dev/mrsas/mrsas_linux.c Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/dev/mrsas/mrsas_linux.c Wed Oct  8 09:30:35 2014 (r272738)
> @@ -39,10 +39,10 @@
>  * Mail to: LSI Corporation, 1621 Barber Lane, Milpitas, CA 95035
>  *    ATTN: MegaRaid FreeBSD
>  *
> + * $FreeBSD$
>  */
> 
> #include <sys/cdefs.h>
> -<!-- $FreeBSD$ -->
> 
> #include <sys/param.h>
> #include <sys/systm.h>
> 
> Modified: head/sys/modules/mrsas/Makefile
> ==============================================================================
> --- head/sys/modules/mrsas/Makefile Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/modules/mrsas/Makefile Wed Oct  8 09:30:35 2014 (r272738)
> @@ -1,5 +1,5 @@
> # Makefile for mrsas driver
> -<!-- $FreeBSD$ -->
> +# $FreeBSD$
> 
> KMOD=mrsas
> .PATH: ${.CURDIR}/../../dev/${KMOD}
> 
> Modified: head/sys/modules/mrsas/mrsas_linux/Makefile
> ==============================================================================
> --- head/sys/modules/mrsas/mrsas_linux/Makefile Wed Oct  8 09:19:35 2014 (r272737)
> +++ head/sys/modules/mrsas/mrsas_linux/Makefile Wed Oct  8 09:30:35 2014 (r272738)
> @@ -1,5 +1,5 @@
> # Makefile for mrsas driver
> -<!-- $FreeBSD$ -->
> +# $FreeBSD$
> 
> .PATH: ${.CURDIR}/../../../dev/mrsas
> 
> 
>