svn commit: r272567 - in head/sys: kern sys

Mateusz Guzik mjguzik at gmail.com
Sun Oct 5 20:47:24 UTC 2014


On Sun, Oct 05, 2014 at 08:26:59PM +0000, Bjoern A. Zeeb wrote:
> 
> On 05 Oct 2014, at 19:40 , Mateusz Guzik <mjg at FreeBSD.org> wrote:
> 
> > Author: mjg
> > Date: Sun Oct  5 19:40:29 2014
> > New Revision: 272567
> > URL: https://svnweb.freebsd.org/changeset/base/272567
> > 
> > Log:
> >  filedesc: fix up breakage introduced in 272505
> > 
> >  Include sequence counter supports incoditionally [1]. This fixes reprted build
> >  problems with e.g. nvidia driver due to missing opt_capsicum.h.
> > 
> >  Replace fishy looking sizeof with offsetof. Make fde_seq the last member in
> >  order to simplify calculations.
> 
> Seing this on an incremental build now for
> 
> bmake: stopped in /scratch/tmp/bz/head.svn/lib/libkvm
> 
> /storage/head/obj//mips.mipsel/scratch/tmp/bz/head.svn/tmp/usr/include/sys/filedesc.h:57: error: expected specifier-qualifier-list before 'seq_t'
> 
> I’ll see if this persists with a full build but I assume it will.
> 

I cannot reproduce it, tried with mips + QEMU config.

One crap thing is that typedef uint32_t seq_t is placed before includes.

Does it help if you move it after systm.h?

Was the failure present prior to this patch?

-- 
Mateusz Guzik <mjguzik gmail.com>


More information about the svn-src-all mailing list