svn commit: r272386 - in head: sbin/ifconfig share/man/man4 sys/net

[Hiroki Sato]

Jean-Sébastien Pédron <dumbbell at FreeBSD.org> wrote
  in <542D9AED.6060805 at FreeBSD.org>:

du> > Author: hrs
du> > Date: Wed Oct  1 21:37:32 2014
du> > New Revision: 272386
du> > URL: https://svnweb.freebsd.org/changeset/base/272386
du> > 
du> > Log:
du> >   Virtualize lagg(4) cloner.  This change fixes a panic when tearing down
du> >   if_lagg(4) interfaces which were cloned in a vnet jail.
du> 
du> Hi!
du> 
du> I believe this change needs at least an entry in UPDATING, because an
du> ifconfig(8) binary built before this commit fails to change laggproto on
du> a kernel including this commit.
du> 
du> The error is the following:
du>     # ifconfig lagg0 laggproto failover
du>     ifconfig: SIOCSLAGG: Invalid argument
du> 
du> By quickly looking at the code, I would say that the culprit is the
du> change in size of the "struct lag_reqall". The new "ra_opts" field in
du> "struct lagg_reqall" isn't initialized in the incompatible ifconfig(8)
du> binary. This could be considered invalid options, leading to "error =
du> EINVAL" in if_lagg.c:1301.
du> 
du> Another non-critical regression is that this ifconfig(8) binary doesn't
du> display the laggproto and laggport lines. I mean those lines:
du>     # ifconfig lagg0
du>     lagg0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> (...)
du> 	(...)
du> 	laggproto failover lagghash l2,l3,l4
du> 	laggport: wlan0 flags=0<>
du> 	laggport: re0 flags=5<MASTER,ACTIVE>
du> 
du> Beside an UPDATING entry, how about a previously released world with
du> this new kernel? Isn't this configuration supposed to work?

 Ah, yes, I was lazy and did not keep the compatibility.  On or after
 r272446 an old ifconfig works with the new kernel.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20141003/9acc3160/attachment.sig>