svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

[Roman Divacky]

On Tue, Nov 11, 2014 at 10:48:36PM +1100, Bruce Evans wrote:
> On Tue, 11 Nov 2014, [utf-8] Dag-Erling Smørgrav wrote:
> 
> > "Bjoern A. Zeeb" <bz at FreeBSD.org> writes:
> >> This fails to compile on all gcc platforms.
> >>
> >> cc1: warnings being treated as errors
> >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c:
> >> In function 'rijndael_padEncrypt':
> >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c:236:
> >> warning: cast discards qualifiers from pointer target type
> >> [...]
> >
> > The code is quite clearly wrong.  Why doesn't clang complain?
> 
> -Wcast-qual is broken (has no effect) with clang.  This is incompatible
> with gcc and defeats the reason of existence of -Wcast-qual.

I implemented -Wcast-qual in clang. We might want to backport it to our 3.4
(3.5 when it's imported), to prevent breakages like this in future.

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141117/118946.html

Roman