svn commit: r274710 - head/sbin/ifconfig

Anton Yuzhaninov citrin at citrin.ru
Wed Nov 19 14:11:23 UTC 2014


On 11/19/14 16:57, Mark Felder wrote:
> New Revision: 274710
> URL: https://svnweb.freebsd.org/changeset/base/274710
>
> Log:
>    Expose groups by default in ifconfig output. This was never hidden by
>    OpenBSD; unsure why we chose to do so. As groups are a requirement for
>    pf, exposing them by default will make our pf implementation less
>    confusing.
...
>
> Modified: head/sbin/ifconfig/ifgroup.c
> ==============================================================================
> --- head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:31:08 2014	(r274709)
> +++ head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:57:39 2014	(r274710)
> @@ -86,9 +86,6 @@ getifgroups(int s)
>   	struct ifgroupreq	 ifgr;
>   	struct ifg_req		*ifg;
>
> -	if (!verbose)
> -		return;

Please return groups output under verbose flag.

pf is used not by all.

And more longer ifconfig output is unhandy. Especially on hosts with many 
interfaces.

Better to document ifconfig -v in pf.conf(5)


More information about the svn-src-all mailing list