svn commit: r274635 - head/sys/dev/pci

[Adrian Chadd]

Hi,

Want to post a bootverbose suspend/resume pass with -HEAD without this
patch in it, then with this patch in it?

We should likely revert this commit (for correctness) and then dig
deeper into what's going on.



-adrian


On 17 November 2014 22:46, Chagin Dmitry <dchagin at freebsd.org> wrote:
> On Mon, Nov 17, 2014 at 05:45:23PM -0500, John Baldwin wrote:
>> On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote:
>> > Author: dchagin
>> > Date: Mon Nov 17 20:25:21 2014
>> > New Revision: 274635
>> > URL: https://svnweb.freebsd.org/changeset/base/274635
>> >
>> > Log:
>> >   Use the correct device as the power_for_sleep() method
>> >   always pass request up to parent bridge.
>> >
>> >   Reviewed by:      jhb
>> >   MFC after:        1 week
>> >   xMFC:             r274386,r274397
>>
>> Hmm, I had misread this diff as being another instance of what Adrian had
>> found.  I think this is actually not correct.  The parent of a pci device
>> ('dev' here) is a pciX device.  pciX devices do not implement the
>> PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke
>> Adrian's Asus laptop as now it will always use D3 again and ignore _SxD.
> ugh.. i understood, let me see more closely
>>
>> You said that this change fixed your laptop, yes?  Did it work before Adrian's
>> change in r274386 and break afterwards?
> yes
>
> --
> Have fun!
> chd