svn commit: r274635 - head/sys/dev/pci
John Baldwin
jhb at freebsd.org
Mon Nov 17 22:46:05 UTC 2014
On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote:
> Author: dchagin
> Date: Mon Nov 17 20:25:21 2014
> New Revision: 274635
> URL: https://svnweb.freebsd.org/changeset/base/274635
>
> Log:
> Use the correct device as the power_for_sleep() method
> always pass request up to parent bridge.
>
> Reviewed by: jhb
> MFC after: 1 week
> xMFC: r274386,r274397
Hmm, I had misread this diff as being another instance of what Adrian had
found. I think this is actually not correct. The parent of a pci device
('dev' here) is a pciX device. pciX devices do not implement the
PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke
Adrian's Asus laptop as now it will always use D3 again and ignore _SxD.
You said that this change fixed your laptop, yes? Did it work before Adrian's
change in r274386 and break afterwards?
--
John Baldwin
More information about the svn-src-all
mailing list