svn commit: r274585 - head/sys/net

Gleb Smirnoff glebius at FreeBSD.org
Mon Nov 17 15:27:50 UTC 2014


On Sun, Nov 16, 2014 at 02:56:32PM +0000, Alexander V. Chernikov wrote:
A> Author: melifaro
A> Date: Sun Nov 16 14:56:31 2014
A> New Revision: 274585
A> URL: https://svnweb.freebsd.org/changeset/base/274585
A> 
A> Log:
A>   Make witness happy: destroy rte lock before free.
A>   MFC after:	2 weeks
A> Modified:
A>   head/sys/net/route.c
A> 
A> Modified: head/sys/net/route.c
A> ==============================================================================
A> --- head/sys/net/route.c	Sun Nov 16 13:57:53 2014	(r274584)
A> +++ head/sys/net/route.c	Sun Nov 16 14:56:31 2014	(r274585)
A> @@ -517,6 +517,7 @@ rtfree(struct rtentry *rt)
A>  		/*
A>  		 * and the rtentry itself of course
A>  		 */
A> +		RT_LOCK_DESTROY(rt);
A>  		uma_zfree(V_rtzone, rt);
A>  		return;
A>  	}

This is not right fix. The lock will be destroyed second time by rtentry_zfini().

Can you please point me at revision that introduced the problem, you are
trying to solve?

-- 
Totus tuus, Glebius.


More information about the svn-src-all mailing list