svn commit: r274186 - head/share/mk

[NGie Cooper]

On Thu, Nov 6, 2014 at 9:21 AM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> On Nov 6, 2014, at 9:19, Warner Losh <imp at freebsd.org> wrote:
>
>> Author: imp
>> Date: Thu Nov  6 17:19:41 2014
>> New Revision: 274186
>> URL: https://svnweb.freebsd.org/changeset/base/274186
>>
>> Log:
>>  Ignore errors from rm -rf to support high -j builds. This is, at best,
>>  a kludge. However, it also effectively works around the issues for
>>  high -j builds on systems that do not have the rm fixes.
>>
>>  A better fix would be to rmdir here, and fix the places where we're
>>  sloppy and not list all the files we create in CLEANFILES, should
>>  anybody have the time to chase them all to ground.
>
> I’ll say that bsd.progs.mk is a huge problem here because CLEANFILES is handled <number of PROGS> times.
>
> Dealing with bsd.progs.mk and its recursive nature is quite entertaining...

Another question related to this commit...

Why aren't return codes ignored for rm -f ${CLEANFILES} ?

bdrewery@ ran into an issue at $work where the build failed after
r268376 because he ran into ESTALE with rm:

13:51 <@bdrewery> rm: fts_open: Stale NFS file handle

This commit will allow the build to continue when dealing with ESTALE
on directories, but it won't fix the case where we hit ESTALE with
CLEANFILES.

Thanks!