svn commit: r273955 - in head: etc/rc.d share/man/man7

[John-Mark Gurney]

Brooks Davis wrote this message on Mon, Nov 03, 2014 at 19:00 +0000:
> On Sun, Nov 02, 2014 at 12:11:26AM +0000, John-Mark Gurney wrote:
> > Author: jmg
> > Date: Sun Nov  2 00:11:25 2014
> > New Revision: 273955
> > URL: https://svnweb.freebsd.org/changeset/base/273955
> > 
> > Log:
> >   add an rc.d script to automatically grow the specified FS...  It has
> >   been tested on both MBR and GPT...  It won't be enabled until you add
> >   growfs_enable="YES" and will only run on first boot..
> 
> Nice.  I've been wanting something like this for our boards.  A few
> comments:
> 
>  - It looks like the current script doesn't support specifying a file
>    system and just finds the root dev.  As a practical matter being able
>    to specify one probably isn't useful without doing the work to extend
>    the last partition on a device, but I could see cases where /usr or the
>    like is on removable media an / is an mdroot or otherwise on fixed size
>    storage.

This wouldn't be hard to fix, but is complicated by the fact that I'm
using awk to do this work, so if /usr is not mounted yet, the script
won't work...

Hmm... I think that this is the bug that is referenced in the comment..

>  - Being able to specify a size would be useful.  For example, I might want
>    to growfs to 2GB by default and expand to the media size later if
>    warranted.

This shouldn't be too hard to add...  Just adding an arg to the resize
command...

>  - A configurable delay during which ^C causes growfs to be skipped would
>    be useful when testing an image.  Growfs on large or very slow media is
>    something I'd like to be able to avoid when I'm just testing.

So, by default, this doesn't run, and I believe also, because of the
firstboot keyword, only when the firstboot file is present...  We
might want to have an option to override that so that it runs on every
boot..

>  - The shell lines should probably use tab for indentation to match system
>    style and the awk bits.

Hmm..  yeh..  I based it on another script that had this style, though
I ended up gutting it, but ended keeping the style...  I'll fix this
up... looks like nsswitch has a similar problem...  I've fixed this
in r274060...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."