svn commit: r265359 - head/sys/modules/sound/sound

[Warner Losh]

On May 5, 2014, at 8:31 AM, Hans Petter Selasky <hselasky at freebsd.org> wrote:

> Author: hselasky
> Date: Mon May  5 14:31:34 2014
> New Revision: 265359
> URL: http://svnweb.freebsd.org/changeset/base/265359
> 
> Log:
>  Build the kernel sound module without ISA DMA support for ARM and MIPS
>  platforms, because these platforms do not implement the ISA DMA
>  API. Else the sound modules cannot be loaded when running these
>  platforms.
> 
>  MFC after:	2 weeks
> 
> Modified:
>  head/sys/modules/sound/sound/Makefile
> 
> Modified: head/sys/modules/sound/sound/Makefile
> ==============================================================================
> --- head/sys/modules/sound/sound/Makefile	Mon May  5 11:50:52 2014	(r265358)
> +++ head/sys/modules/sound/sound/Makefile	Mon May  5 14:31:34 2014	(r265359)
> @@ -44,7 +44,8 @@ CLEANFILES+=	feeder_eq_gen.h feeder_rate
> 
> EXPORT_SYMS=	YES	# XXX evaluate
> 
> -.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc"
> +.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" || \
> +    ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "mips"
> # Create an empty opt_isa.h in order to keep kmod.mk from linking in an
> # existing one from KERNBUILDDIR which possibly has DEV_ISA defined so
> # sound.ko is always built without isadma support.

Rather than an opt-in approach here, why not lust list the three that have it since
they are the only ones that will ever have it…

Warner