svn commit: r265289 - head/sys/dev/gpio

Luiz Otavio O Souza loos at FreeBSD.org
Sat May 3 20:33:01 UTC 2014


Author: loos
Date: Sat May  3 20:33:00 2014
New Revision: 265289
URL: http://svnweb.freebsd.org/changeset/base/265289

Log:
  Really sort out the headers.
  
  sys/systm.h must always come after sys/param.h.
  
  Remove sys/types.h which should never be included together with sys/param.h.
  
  Add sys/malloc.h for correctness even if it seems to don't be needed.
  
  Remove more unused headers found by unusedinc (from bde@) and tested with a
  universe build.
  
  Reported by:	bde

Modified:
  head/sys/dev/gpio/gpiobus.c
  head/sys/dev/gpio/gpiobusvar.h
  head/sys/dev/gpio/ofw_gpiobus.c

Modified: head/sys/dev/gpio/gpiobus.c
==============================================================================
--- head/sys/dev/gpio/gpiobus.c	Sat May  3 20:22:13 2014	(r265288)
+++ head/sys/dev/gpio/gpiobus.c	Sat May  3 20:33:00 2014	(r265289)
@@ -28,13 +28,11 @@
 __FBSDID("$FreeBSD$");
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/bus.h>
-#include <sys/gpio.h>
 #include <sys/kernel.h>
 #include <sys/malloc.h>
 #include <sys/module.h>
-#include <sys/systm.h>
-#include <sys/types.h>
 
 #include <dev/gpio/gpiobusvar.h>
 

Modified: head/sys/dev/gpio/gpiobusvar.h
==============================================================================
--- head/sys/dev/gpio/gpiobusvar.h	Sat May  3 20:22:13 2014	(r265288)
+++ head/sys/dev/gpio/gpiobusvar.h	Sat May  3 20:33:00 2014	(r265289)
@@ -32,7 +32,6 @@
 
 #include "opt_platform.h"
 
-#include <sys/param.h>
 #include <sys/lock.h>
 #include <sys/mutex.h>
 

Modified: head/sys/dev/gpio/ofw_gpiobus.c
==============================================================================
--- head/sys/dev/gpio/ofw_gpiobus.c	Sat May  3 20:22:13 2014	(r265288)
+++ head/sys/dev/gpio/ofw_gpiobus.c	Sat May  3 20:33:00 2014	(r265289)
@@ -30,18 +30,16 @@
 __FBSDID("$FreeBSD$");
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/bus.h>
-#include <sys/gpio.h>
 #include <sys/kernel.h>
+#include <sys/malloc.h>
 #include <sys/module.h>
-#include <sys/systm.h>
 
 #include <dev/gpio/gpiobusvar.h>
 #include <dev/ofw/ofw_bus.h>
-#include <dev/ofw/openfirm.h>
 
 #include "gpio_if.h"
-#include "gpiobus_if.h"
 
 static int ofw_gpiobus_parse_gpios(struct gpiobus_softc *,
     struct gpiobus_ivar *, phandle_t);


More information about the svn-src-all mailing list