svn commit: r263755 - head/sys/kern

[Mateusz Guzik]

On Sat, Mar 29, 2014 at 11:52:09AM +0800, David Xu wrote:
> >If fsetown handling like this is insecure this would bite us in that
> >scenario (and few others). In short, if we can avoid giving another way
> >to corrupt stuff in the kernel to userspace, we should.
> >
> I can not see what you said, where is the security problem with fsetown ?
> if you have per-jail instance of devsoftc, they all are operating on their
> own instance. but I don't think this patch should address jail now, there
> are many things are not jail ready.
> 

I asked if multpiple concurrent calls to fsetown(.., &pointer) could
result in some corruption in the kernel - if they could, we would have a
problem in the future.

I decided to read the code once more and fsetown seems to be safe in
this regard after all and with that in mind the patch looks good to me.

This thread is too long already, so I'm stepping down on this one in
case there are some futher concerns.

-- 
Mateusz Guzik <mjguzik gmail.com>