svn commit: r268028 - head/sys/dev/e1000

[Adrian Chadd]

Fixed in both! thanks!


-a


On 30 June 2014 08:06, Luigi Rizzo <rizzo at iet.unipi.it> wrote:
> On Mon, Jun 30, 2014 at 04:56:01PM +0200, Luigi Rizzo wrote:
>> I am getting the following error while compiling with gcc:
>>
>> cc1: warnings being treated as errors
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c: In function
>> 'igb_attach':
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: warning: 'cpu_id'
>> may be used uninitialized in this function
>> /usr/home/luigi/FreeBSD/head/sys/dev/e1000/if_igb.c:2461: note: 'cpu_id'
>> was declared here
>>
>> (the code is correct, apparently gcc cannot understand that).
>>
>> For compatibility i'd throw in an explicit initialization,
>> however it might be worthwhile rewriting the code with a single
>> if (adapter->num_queues > 1) { ...} block within the for(),
>> and also using only one #ifdef RSS -- the other places only
>> differ in the string passed to diagnostics or comments.
>
> and the same goes for the recent changes to ixgbe.c
>
> cheers
> luigi