svn commit: r267758 - head

Warner Losh imp at bsdimp.com
Tue Jun 24 16:08:16 UTC 2014


On Jun 22, 2014, at 6:54 PM, Andrey A. Chernov <ache at FreeBSD.org> wrote:

> Author: ache
> Date: Mon Jun 23 00:54:56 2014
> New Revision: 267758
> URL: http://svnweb.freebsd.org/changeset/base/267758
> 
> Log:
>  Change suggestion how to set MAKESYSPATH as broken incremental build
>  workaround. Magic ".../share/mk" (search directories up to /)
>  does not work for f.e. /usr/src/gnu/lib/libgcc because the path
>  inside is starting from /usr/obj hierarchy and ends up in
>  /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is.
>  IMHO proper fixing of incremental build is needed urgently.

I don’t understand how this is even possible. This change is wrong because it has a bogus path the doesn’t exist on all systems. I’m going to fix that.

Agreed on incremental builds, but that is turning out to be harder than expected. It is broken, but adding broken advise is even worse.

Warner


> Modified:
>  head/UPDATING
> 
> Modified: head/UPDATING
> ==============================================================================
> --- head/UPDATING	Sun Jun 22 23:40:20 2014	(r267757)
> +++ head/UPDATING	Mon Jun 23 00:54:56 2014	(r267758)
> @@ -67,7 +67,7 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11
> 	behavior back, you can .include /etc/src.conf from /etc/make.conf
> 	(which is still global and isn't changed). This also changes the
> 	behavior of incremental builds inside the tree of individual
> -	directories. Set MAKESYSPATH to ".../share/mk" to do that.
> +	directories. Set MAKESYSPATH to "/usr/src/share/mk" to do that.
> 	Although this has survived make universe and some upgrade scenarios,
> 	other upgrade scenarios may have broken. At least one form of
> 	temporary breakage was fixed with MAKESYSPATH settings for buildworld
> 



More information about the svn-src-all mailing list