svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Bjoern A. Zeeb]

On 03 Jun 2014, at 21:06 , Alexander Motin <mav at FreeBSD.org> wrote:

> Author: mav
> Date: Tue Jun  3 21:06:03 2014
> New Revision: 267029
> URL: http://svnweb.freebsd.org/changeset/base/267029
> 
> Log:
>  Replace gethrtime() with cpu_ticks(), as source of random for the taskqueue
>  selection.  gethrtime() in our port updated with HZ rate, so unusable for
>  this specific purpose, completely draining benefit of multiple taskqueues.
> 
>  MFC after:	2 weeks
> 

I am seeing this now for all buildworld targets:

/storage/head/obj//arm.armeb/scratch/tmp/bz/head.svn/tmp/usr/lib/libzpool.so: undefined reference to `cpu_ticks'


> Modified:
>  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c
> 
> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c
> ==============================================================================
> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c	Tue Jun  3 21:02:19 2014	(r267028)
> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c	Tue Jun  3 21:06:03 2014	(r267029)
> @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t
> 	if (tqs->stqs_count == 1) {
> 		tq = tqs->stqs_taskq[0];
> 	} else {
> -		tq = tqs->stqs_taskq[gethrtime() % tqs->stqs_count];
> +		tq = tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count];
> 	}
> 
> 	taskq_dispatch_ent(tq, func, arg, flags, ent);
> 

— 
Bjoern A. Zeeb             "Come on. Learn, goddamn it.", WarGames, 1983