svn commit: r266970 - stable/10/sys/geom

[Andrey V. Elsukov]

On 02.06.2014 17:07, Ian Lepore wrote:
>> ==============================================================================
>> --- stable/10/sys/geom/geom_event.c	Mon Jun  2 07:08:34 2014	(r266969)
>> +++ stable/10/sys/geom/geom_event.c	Mon Jun  2 10:14:03 2014	(r266970)
>> @@ -206,6 +206,14 @@ g_orphan_register(struct g_provider *pp)
>>  		KASSERT(cp->geom->orphan != NULL,
>>  		    ("geom %s has no orphan, class %s",
>>  		    cp->geom->name, cp->geom->class->name));
>> +		/*
>> +		 * XXX: g_dev_orphan method does deferred destroying
>> +		 * and it is possible, that other event could already
>> +		 * call the orphan method. Check consumer's flags to
>> +		 * do not schedule it twice.
>> +		 */
>> +		if (cp->flags & G_CF_ORPHAN)
>> +			continue;
>>  		cp->flags |= G_CF_ORPHAN;
>>  		cp->geom->orphan(cp);
>>  	}
>>
> 
> Why is this comment flagged with XXX?  Doesn't that generally mean that
> more action or further analysis in the future is required?  Nothing
> about the comment itself indicates that there's more work to do.

I suspect that there are some another places, where similar problem can
occurs. It needs more attention. I just did fix for the easy
reproducible panic.

-- 
WBR, Andrey V. Elsukov