svn commit: r269112 - head/sys/boot/arm/at91/boot2

Benjamin Kaduk bjkfbsd at gmail.com
Sat Jul 26 14:33:04 UTC 2014


On Sat, Jul 26, 2014 at 12:09 AM, Ian Lepore <ian at freebsd.org> wrote:

> Author: ian
> Date: Sat Jul 26 04:09:43 2014
> New Revision: 269112
> URL: http://svnweb.freebsd.org/changeset/base/269112
>
> Log:
>   The 'flags' variable is conflicting with some inline code in a header
> file
>   ("variable flags shadows a global..."), just rename this variable to
>   wish away the problem.
>

Not trying to pick on you, but we have lots of places where we get
"variable <foo> shadows a global..." -- we have a global variable 'buf' in
the kernel namespace, for one :)
Do we think it's a good use of our time to try and get this to zero
instances?

-Ben


More information about the svn-src-all mailing list