svn commit: r268543 - in head/sys: dev/drm2 dev/drm2/i915 dev/drm2/radeon dev/etherswitch/arswitch dev/etherswitch/rtl8366 dev/iicbus sys

[Ian Lepore]

On Fri, 2014-07-11 at 18:48 -0700, Rui Paulo wrote:
> On Jul 11, 2014, at 18:42, Ian Lepore <ian at FreeBSD.org> wrote:
> 
> > On Sat, 2014-07-12 at 01:04 +0000, Rui Paulo wrote:
> >> Author: rpaulo
> >> Date: Sat Jul 12 01:04:10 2014
> >> New Revision: 268543
> >> URL: http://svnweb.freebsd.org/changeset/base/268543
> >> 
> >> Log:
> >>  Move iic.h to sys/ so that it's automatically installed in /usr/include/sys.
> >> 
> >>  This lets us call iic(4) ioctls without needing the kernel source code
> >>  and follows the same model of GPIO.
> >> 
> >>  MFC after:	3 weeks
> > 
> > It was already available in /usr/include/dev/iicbus, and now it's not
> > going to be, potentially breaking out-of-tree stuff.  Hrm... in fact
> > definitely breaking it, we have references to dev/iicbus/iic.h in our
> > apps at $work.
> 
> Hmm.  In that case, which one is correct?  Should sys/gpio.h exist?
> 
> --
> Rui Paulo
> 

sys/gpio.h feels out of place to me -- it's device stuff, it should live
in include/dev/gpio.  Moving it now might create the same sort of
trouble for out-of-tree code, unless we also put a symlink in the old
location.

-- Ian