svn commit: r268491 - head/usr.bin/users

[Ian Lepore]

On Thu, 2014-07-10 at 11:27 -0400, John Baldwin wrote:
> On Thursday, July 10, 2014 11:04:56 am Ed Schouten wrote:
> > On 10 July 2014 14:15, Pietro Cerutti <gahr at freebsd.org> wrote:
> > > +using namespace std;
> > 
> > Out of curiosity, do we have any style guidelines w.r.t. C++? For
> > example, I would personally not use things like "using namespace std".
> > It becomes hard to figure out where symbols come from.
> 
> I would also prefer avoiding 'using namespace' when possible, especially for
> a short program.
> 
> > > +       sort(begin(names), end(names));
> > > +       vector<string>::iterator last(unique(begin(names), end(names)));

Seriously?  We want this completely readable line changed to:

        std::vector<std::string>::iterator last(std::unique(
            std::begin(names), std::end(names)));

If so we REALLY need to revist the 80-column limitation.

I think "using namespace std;" is enough of an idiom in C++ that it
should be allowed and even encouraged unless there's a good reason not
to use it.

-- Ian

> > This could also just be a std::set, right?
> > 
> > Even though I actually think C++ is a lot nicer than C, do we really
> > think it is actually worth proactively replacing already existent
> > tools? This specific tool has now become three times as big as the
> > previous version (7128 -> 23840 bytes).
> 
> It'd be even shorter code (and a larger runtime footprint) to write it in
> python. :)
>