svn commit: r268420 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Alexander Motin]

Author: mav
Date: Tue Jul  8 17:26:08 2014
New Revision: 268420
URL: http://svnweb.freebsd.org/changeset/base/268420

Log:
  Remove IO_SYNC flag when writing extended file attributes on ZFS.
  
  While it is possible to create and write file, modify its permissions, etc.
  without ever doing sync, it looks odd that it is required for setting
  extended file attributes on ZFS.  UFS does not do sync there too.
  
  Samba uses those extended attributes to store some its data, and doing it
  synchronously by many times reduces file creation performance for systems
  without SLOG device.
  
  Reviewed by:	delphij, jpaetzel, silence on fs@
  MFC after:	2 weeks
  Sponsored by:	iXsystems, Inc.

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Tue Jul  8 16:56:21 2014	(r268419)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Tue Jul  8 17:26:08 2014	(r268420)
@@ -6875,7 +6875,7 @@ vop_setextattr {
 	va.va_size = 0;
 	error = VOP_SETATTR(vp, &va, ap->a_cred);
 	if (error == 0)
-		VOP_WRITE(vp, ap->a_uio, IO_UNIT | IO_SYNC, ap->a_cred);
+		VOP_WRITE(vp, ap->a_uio, IO_UNIT, ap->a_cred);
 
 	VOP_UNLOCK(vp, 0);
 	vn_close(vp, flags, ap->a_cred, td);