svn commit: r261014 - head/sys/dev/usb/wlan

[Hans Petter Selasky]

On 01/23/14 10:39, Kevin Lo wrote:
>
> On 2014/01/22 17:57, Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Wed Jan 22 09:57:26 2014
>> New Revision: 261014
>> URL: http://svnweb.freebsd.org/changeset/base/261014
>>
>> Log:
>>    - Fix some non-portable code with regard to endianness. Don't use
>> memmove().
>>    - Fix a range check for maximum transmit length.
>>    - Fix read from missing field when transmitting data.
>>    MFC after:    2 weeks
>
> I appreciate you're taking the time to fix code, but your change totally
> breaks RT3573 and IQ calibration doesn't work for RT5372 and RT5572.
> I think it'd be good to send me the patch for testing/review
> before committing.  Thanks!
>
>      Kevin
>
>

Hi Kevin,

That's fine. I don't have that chipset to test with. My dongle was 
working fine with the given patches. The fixes were based on code 
inspection. Will you send a new patch to fix the issues I've mentioned 
today? There are clearly some bugs in there either with or without the 
patch.

Thank you!

--HPS