svn commit: r260702 - head/sys/netinet

[John-Mark Gurney]

Alexander V. Chernikov wrote this message on Thu, Jan 16, 2014 at 11:50 +0000:
> Author: melifaro
> Date: Thu Jan 16 11:50:00 2014
> New Revision: 260702
> URL: http://svnweb.freebsd.org/changeset/base/260702
> 
> Log:
>   Fix ipfw fwd for IPv4 traffic broken by r249894.
>   
>   Problem case:
>   Original lookup returns route with GW set, so gw points to
>   rte->rt_gateway.
>   After that we're changing dst and performing lookup another time.
>   Since fwd host is most probably directly reachable, resulting
>   rte does not contain rt_gateway, so gw is not set. Finally, we
>   end with packet transmitted to proper interface but wrong
>   link-layer address.
>   
>   Found by:	lstewart
>   Discussed with:	ae,lstewart
>   MFC after:	2 weeks
>   Sponsored by:	Yandex LLC

This may be needed for 10.0 as this sounds suspiciously familar to
the recent multicast code that was fixed too...

It sounds like someone needs to audit this code to verify that there
are no other code paths that can break because of this.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."